Conversation
Closed
ESadek-MO
reviewed
Sep 18, 2024
Contributor
ESadek-MO
left a comment
ESadek-MO
left a comment
There was a problem hiding this comment.
Couple questions, but generally looks good
|
|
||
|
|
||
| [testenv:py{39,310,311}-lock] | ||
| [testenv:py{310,311,312}-lock] |
Collaborator
There was a problem hiding this comment.
There are some missing corresponding changes. This is creating some confusing conflicts with #423. I could raise a pull request to fix these if you're OK with that?
Lines 8 to 12 in 8a82027
Lines 45 to 46 in 8a82027
cf-units/.github/workflows/ci-locks.yml
Lines 28 to 30 in 8a82027
cf-units/.github/workflows/ci-tests.yml
Lines 33 to 42 in 8a82027
Line 50 in 8a82027
Lines 36 to 45 in 8a82027
This was referenced Sep 20, 2024
Closed
stephenworsley
added a commit
to rcomer/cf-units
that referenced
this pull request
Sep 24, 2024
* main: [pre-commit.ci] pre-commit autoupdate (SciTools#425) Adopt cython3 (require >=3) (SciTools#460) Add repo-review (SciTools#456) Fully support Python 3.12 (SciTools#461) Bump peter-evans/create-pull-request from 6.0.4 to 7.0.5 (SciTools#459) Fix for bad git path in GHA macos instances. (SciTools#464) test macos wheels (SciTools#458) Bump pypa/cibuildwheel from 2.20.0 to 2.21.1 (SciTools#457) Fixes for CI wheels (SciTools#455) Dependabot check weekly. (SciTools#439) # Conflicts: # .pre-commit-config.yaml # cf_units/tests/test_coding_standards.py # pyproject.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description